Fix random coverage in std.algorithm.sorting#5572
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jul 7, 2017
Merged
Conversation
wilzbach
added
Infrastructure:automation
Review:Trivial
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
CyberShadow
approved these changes
Jul 7, 2017
Member
|
Obvious bugfix aside, did you check that the |
Contributor
Author
Yep, that's how I noticed the bug ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The random coverage error appearing in #5570, is, as usual, our fault.
https://codecov.io/gh/dlang/phobos/compare/551ffa6e0d247dcdb560feb2e297346886de17d0...8cf459324303a19307ec173d36596dff99d71a11/changes
However, this one can be fixed easily - we just need to use the fixed seeds for the random number generator ;-)